fix: do not allow image markdown in assertions and command log #17777

sainthkh · 2021-08-18T00:58:47Z

Do not allow image markdown in assertions and command log

Why was this change necessary? => Image markdowns are interpreted in command log and it makes it hard for us to understand the assertion message.
What is affected by this change? => N/A
Any implementation details to explain? => By escaping markdowns.

Before:

After:

cypress-bot · 2021-08-18T00:58:49Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

sainthkh · 2021-08-18T01:25:55Z

flaky failures.

jennifer-shehane · 2021-08-19T12:58:57Z

Hey @sainthkh, I sent you an email at the email listed on your GitHub if you can check. Thanks.

jennifer-shehane

Looks great, testing manually also. Thanks!

fix

b1e25c1

sainthkh marked this pull request as ready for review August 18, 2021 01:22

sainthkh requested a review from a team as a code owner August 18, 2021 01:22

sainthkh requested review from chrisbreiding and jennifer-shehane and removed request for a team August 18, 2021 01:22

jennifer-shehane assigned sainthkh Aug 18, 2021

jennifer-shehane approved these changes Aug 19, 2021

View reviewed changes

jennifer-shehane merged commit 6eed2e6 into cypress-io:develop Aug 19, 2021

cypress-bot bot mentioned this pull request Aug 19, 2021

Do not allow image markdown in assertions and Command Log #17357

Closed

Provide feedback